chore(tanstackstart-react)!: Remove empty placeholder implementations #18338

nicohrubec · 2025-11-26T17:16:44Z

Just cleaning up, we won't be needing any of these. I am aware this is breaking, but I think it's fine since we are still in alpha and these are empty anyways.

sentry · 2025-11-27T08:31:21Z

packages/tanstackstart-react/src/server/index.ts

  return props.children;
 };

-/**
- * A passthrough redux enhancer for the server that doesn't depend on anything from the `@sentry/react` package.
- */
-export function createReduxEnhancer() {
-  return (createStore: unknown) => createStore;
-}
-
 /**
 * A passthrough error boundary wrapper for the server that doesn't depend on any react. Error boundaries don't catch
 * SSR errors so they should simply be a passthrough.


Bug: createReduxEnhancer() and showReportDialog() are declared in types but are undefined at runtime on the server, causing TypeError.
_{Severity: CRITICAL | Confidence: High}

🔍 Detailed Analysis

The PR removes createReduxEnhancer() and showReportDialog() from packages/tanstackstart-react/src/server/index.ts. However, their type declarations persist in packages/tanstackstart-react/src/index.types.ts. This allows TypeScript to permit calls to Sentry.createReduxEnhancer() and Sentry.showReportDialog() on the server. At runtime, these functions are undefined because they are no longer exported, leading to a TypeError: ... is not a function if invoked.

💡 Suggested Fix

Remove or update the type declarations for createReduxEnhancer() and showReportDialog() in packages/tanstackstart-react/src/index.types.ts to align with their removal from server/index.ts.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/tanstackstart-react/src/server/index.ts#L16-L21 Potential issue: The PR removes `createReduxEnhancer()` and `showReportDialog()` from `packages/tanstackstart-react/src/server/index.ts`. However, their type declarations persist in `packages/tanstackstart-react/src/index.types.ts`. This allows TypeScript to permit calls to `Sentry.createReduxEnhancer()` and `Sentry.showReportDialog()` on the server. At runtime, these functions are `undefined` because they are no longer exported, leading to a `TypeError: ... is not a function` if invoked.

_{Did we get this right? 👍 / 👎 to inform future reviews.}
_{Reference ID: 3982457}

cursor

Bug: Breaking change: removed publicly exported server-side functions (Bugbot Rules)

Flagging this because the review rules mention to flag removal of publicly exported functions. The createReduxEnhancer and showReportDialog functions are removed from the server module, but they're still declared as exports in index.types.ts. Since @sentry/node doesn't export these functions, isomorphic code importing them from @sentry/tanstackstart-react will get runtime errors on the server while TypeScript indicates they exist. The previous passthrough implementations allowed these functions to be safely called in code running on both client and server.

packages/tanstackstart-react/src/server/index.ts#L17-L28

sentry-javascript/packages/tanstackstart-react/src/server/index.ts

Lines 17 to 28 in 3c402fe

    
           }; 
        
           /** 
        
            * A passthrough error boundary wrapper for the server that doesn't depend on any react. Error boundaries don't catch 
        
            * SSR errors so they should simply be a passthrough. 
        
            */ 
        
           // eslint-disable-next-line @typescript-eslint/no-explicit-any 
        
           export function withErrorBoundary<P extends Record<string, any>>( 
        
             WrappedComponent: React.ComponentType<P>, 
        
           ): React.FC<P> { 
        
             return WrappedComponent as React.FC<P>; 
        
           }

s1gr1d

Since it's alpha, we can break that (as you already wrote). I added a ! to the title to mark it as breaking.

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | [`10.27.0` -> `10.28.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/10.27.0/10.28.0) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@sentry%2freact/10.28.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@sentry%2freact/10.27.0/10.28.0?slim=true) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@sentry/react)</summary> ### [`v10.28.0`](https://github.com/getsentry/sentry-javascript/releases/tag/10.28.0) [Compare Source](getsentry/sentry-javascript@10.27.0...10.28.0) ##### Important Changes - **feat(core): Make `matcher` parameter optional in `makeMultiplexedTransport` ([#10798](getsentry/sentry-javascript#10798 The `matcher` parameter in `makeMultiplexedTransport` is now optional with a sensible default. This makes it much easier to use the multiplexed transport for sending events to multiple DSNs based on runtime configuration. **Before:** ```javascript import { makeFetchTransport, makeMultiplexedTransport } from '@sentry/browser'; const EXTRA_KEY = 'ROUTE_TO'; const transport = makeMultiplexedTransport(makeFetchTransport, args => { const event = args.getEvent(); if (event?.extra?.[EXTRA_KEY] && Array.isArray(event.extra[EXTRA_KEY])) { return event.extra[EXTRA_KEY]; } return []; }); Sentry.init({ transport, // ... other options }); // Capture events with routing info Sentry.captureException(error, { extra: { [EXTRA_KEY]: [ { dsn: 'https://key1@sentry.io/project1', release: 'v1.0.0' }, { dsn: 'https://key2@sentry.io/project2' }, ], }, }); ``` **After:** ```javascript import { makeFetchTransport, makeMultiplexedTransport, MULTIPLEXED_TRANSPORT_EXTRA_KEY } from '@sentry/browser'; // Just pass the transport generator - the default matcher handles the rest! Sentry.init({ transport: makeMultiplexedTransport(makeFetchTransport), // ... other options }); // Capture events with routing info using the exported constant Sentry.captureException(error, { extra: { [MULTIPLEXED_TRANSPORT_EXTRA_KEY]: [ { dsn: 'https://key1@sentry.io/project1', release: 'v1.0.0' }, { dsn: 'https://key2@sentry.io/project2' }, ], }, }); ``` The default matcher looks for routing information in `event.extra[MULTIPLEXED_TRANSPORT_EXTRA_KEY]`. You can still provide a custom matcher function for advanced use cases. - **feat(nextjs): Support cacheComponents on turbopack ([#18304](getsentry/sentry-javascript#18304 This release adds support for `cacheComponents` on turbopack builds. We are working on adding support for this feature in webpack builds as well. ##### Other Changes - feat: Publish AWS Lambda Layer for Node 24 ([#18327](getsentry/sentry-javascript#18327)) - feat(browser): Expose langchain instrumentation ([#18342](getsentry/sentry-javascript#18342)) - feat(browser): Expose langgraph instrumentation ([#18345](getsentry/sentry-javascript#18345)) - feat(cloudflare): Allow specifying a custom fetch in Cloudflare transport options ([#18335](getsentry/sentry-javascript#18335)) - feat(core): Add `isolateTrace` option to `Sentry.withMonitor()` ([#18079](getsentry/sentry-javascript#18079)) - feat(deps): bump [@sentry/webpack-plugin](https://github.com/sentry/webpack-plugin) from 4.3.0 to 4.6.1 ([#18272](getsentry/sentry-javascript#18272)) - feat(nextjs): Add cloudflare `waitUntil` detection ([#18336](getsentry/sentry-javascript#18336)) - feat(node): Add LangChain v1 support ([#18306](getsentry/sentry-javascript#18306)) - feat(remix): Add parameterized transaction naming for routes ([#17951](getsentry/sentry-javascript#17951)) - fix(cloudflare): Keep http root span alive until streaming responses are consumed ([#18087](getsentry/sentry-javascript#18087)) - fix(cloudflare): Wait for async events to finish ([#18334](getsentry/sentry-javascript#18334)) - fix(core): `continueTrace` doesn't propagate given trace ID if active span exists ([#18328](getsentry/sentry-javascript#18328)) - fix(node-core): Handle custom scope in log messages without parameters ([#18322](getsentry/sentry-javascript#18322)) - fix(opentelemetry): Ensure Sentry spans don't leak when tracing is disabled ([#18337](getsentry/sentry-javascript#18337)) - fix(react-router): Use underscores in trace origin values ([#18351](getsentry/sentry-javascript#18351)) - chore(tanstackstart-react): Export custom inits from tanstackstart-react ([#18369](getsentry/sentry-javascript#18369)) - chore(tanstackstart-react)!: Remove empty placeholder implementations ([#18338](getsentry/sentry-javascript#18338)) <details> <summary><strong>Internal Changes</strong></summary> - chore: Allow URLs as issue ([#18372](getsentry/sentry-javascript#18372)) - chore(changelog): Add entry for [#18304](getsentry/sentry-javascript#18304) ([#18329](getsentry/sentry-javascript#18329)) - chore(ci): Add action to track all PRs as issues ([#18363](getsentry/sentry-javascript#18363)) - chore(github): Adjust `BUGBOT.md` rules to flag invalid op and origin values during review ([#18352](getsentry/sentry-javascript#18352)) - ci: Add action to create issue on gitflow merge conflicts ([#18319](getsentry/sentry-javascript#18319)) - ci(deps): bump actions/checkout from 5 to 6 ([#18268](getsentry/sentry-javascript#18268)) - ci(deps): bump peter-evans/create-pull-request from 7.0.8 to 7.0.9 ([#18361](getsentry/sentry-javascript#18361)) - test(cloudflare): Add typechecks for cloudflare-worker e2e test ([#18321](getsentry/sentry-javascript#18321)) </details> #### Bundle size 📦 | Path | Size | | ----------------------------------------------------------------------------------------------------- | --------- | | [@sentry/browser](https://github.com/sentry/browser) | 24.22 KB | | [@sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 22.76 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 40.57 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Profiling) | 45.05 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 78.08 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 68.05 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 82.65 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 94.61 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 40.51 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 28.8 KB | | [@sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 33.66 KB | | [@sentry/react](https://github.com/sentry/react) | 25.9 KB | | [@sentry/react](https://github.com/sentry/react) (incl. Tracing) | 42.72 KB | | [@sentry/vue](https://github.com/sentry/vue) | 28.56 KB | | [@sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 42.32 KB | | [@sentry/svelte](https://github.com/sentry/svelte) | 24.24 KB | | CDN Bundle | 26.57 KB | | CDN Bundle (incl. Tracing) | 41.22 KB | | CDN Bundle (incl. Tracing, Replay) | 76.9 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 82.23 KB | | CDN Bundle - uncompressed | 78.09 KB | | CDN Bundle (incl. Tracing) - uncompressed | 122.4 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 235.71 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 248.17 KB | | [@sentry/nextjs](https://github.com/sentry/nextjs) (client) | 44.88 KB | | [@sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 40.92 KB | | [@sentry/node-core](https://github.com/sentry/node-core) | 50.06 KB | | [@sentry/node](https://github.com/sentry/node) | 155.7 KB | | [@sentry/node](https://github.com/sentry/node) - without tracing | 90.67 KB | | [@sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 105.61 KB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.foxden.network/foxCaves/foxCaves/pulls/12 Co-authored-by: Renovate <renovate@foxden.network> Co-committed-by: Renovate <renovate@foxden.network>

chore(tanstack): Remove unnecessary placeholder functions

77db267

nicohrubec changed the title ~~chore(tanstack): Remove empty placeholder implementations~~ chore(tanstackstart-react): Remove empty placeholder implementations Nov 26, 2025

nicohrubec requested review from Lms24, andreiborza and s1gr1d November 26, 2025 17:22

nicohrubec self-assigned this Nov 26, 2025

fix lint

3c402fe

nicohrubec marked this pull request as ready for review November 27, 2025 08:29

sentry bot reviewed Nov 27, 2025

View reviewed changes

cursor bot reviewed Nov 27, 2025

View reviewed changes

s1gr1d changed the title ~~chore(tanstackstart-react): Remove empty placeholder implementations~~ chore(tanstackstart-react)!: Remove empty placeholder implementations Nov 27, 2025

s1gr1d approved these changes Nov 27, 2025

View reviewed changes

nicohrubec merged commit 9afaabf into develop Nov 27, 2025
34 checks passed

nicohrubec deleted the nh/remove-tanstack-placeholders branch November 27, 2025 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(tanstackstart-react)!: Remove empty placeholder implementations #18338

chore(tanstackstart-react)!: Remove empty placeholder implementations #18338

Uh oh!

nicohrubec commented Nov 26, 2025 •

edited

Loading

Uh oh!

sentry bot Nov 27, 2025

Uh oh!

cursor bot left a comment

Uh oh!

s1gr1d left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	};

	/**
	* A passthrough error boundary wrapper for the server that doesn't depend on any react. Error boundaries don't catch
	* SSR errors so they should simply be a passthrough.
	*/
	// eslint-disable-next-line @typescript-eslint/no-explicit-any
	export function withErrorBoundary<P extends Record<string, any>>(
	WrappedComponent: React.ComponentType<P>,
	): React.FC<P> {
	return WrappedComponent as React.FC<P>;
	}

Uh oh!

chore(tanstackstart-react)!: Remove empty placeholder implementations #18338

chore(tanstackstart-react)!: Remove empty placeholder implementations #18338

Uh oh!

Conversation

nicohrubec commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentry bot Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Breaking change: removed publicly exported server-side functions (Bugbot Rules)

Uh oh!

s1gr1d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicohrubec commented Nov 26, 2025 •

edited

Loading